Skip to main content
Docs
Feature Requests Onboarding Trust Center Status Page

Community

Connector Improvement: GitHub - Add 'teams' to pull_request_review table

Completed
Orpita Das User
  • Edited

Requested by Nathan Sfard, Cloud Security Engineer, Snowflake:
In fivetran.github.pull_request_review we are ingesting only user reviews, not team reviews. I'd like us to also ingest team reviews. You can see more information on this distinction in the official REST API Reference: https://docs.github.com/en/rest/reference/pulls#list-requested-reviewers-for-a-pull-request (you can see their's two fields in the response: "users" and "teams"; I'd like fivetran to ingest both instead of just "users")

Please sign in to leave a comment.

Comments

7 comments

Date Votes
  • Official comment
    Erin Fivetranner

    Hi Orpita - 

    I wanted to let you know that we have updated the schema for GitHub's REQUESTED_REVIEW_HISTORY table. You will now see a requested_reviewer_type field which is of values (TEAM or USER) depending on that you can join to your TEAM or USER table respectively. The requested_id field now contains both Teams and Users. 

    You can view the entire change log here. The ERD should be updated on the site shortly! 

    Best,

    Erin

  • Erin Fivetranner

    Hi Orpita and Nathan  - Erin, Product Manager for Engineering Connectors here!

    Thanks for submitting this request! I've added this to our backlog but we currently don't have this planned at this time. 

    Can you provide some more information on the use case for not only users but also teams? This will help us prioritize this request. 

    Best, 
    Erin 

  • Orpita Das User

    Hello Erin,

    Review requests can be sent to both 'users' & 'teams'. 
    Nathan says that the Fivetran  'pull_request_review' table lacks 'teams' information, ie. 50% missing information in a table intended to compile the namesake 'review requests'. 

    Is this perhaps an 'enterprise-only' GitHub feature, so your team missed it? 


  • Erin Fivetranner

    Hi Orpita - 

    We have taken this feature request up in our current sprint.

    I'm curious though, does Snowflake use GitHub Enterprise? 

    Best, 

    Erin 

  • Orpita Das User

    Hello Erin, 
    That is great news. 
    We do use GitHub Enterprise. 

  • Orpita Das User

    This is excellent news! Thank you for letting us know. 

    (I don't see this table in my connector schema though. I will check the permissions on the GitHub account on my end.)

  • Orpita Das User

    Oh I see it in the documentation, that I need to contact support. I will do this. 

    This feature is available for connectors created after February 1, 2022. If you want to enable the feature for connectors created before February 2, 2022, contact our support team.