Skip to main content
Docs
Feature Requests Onboarding Trust Center Status Page

Community

Connector Improvement: Sync Github reviews/id/comments

Completed
Nathan Vos User

This endpoint currently isn't synced. Would be great to have the full comment history on PR reviews.

Please sign in to leave a comment.

Comments

5 comments

Date Votes
  • Official comment
    Erin Fivetranner

    Hi Nathan - 

    Thanks for submitting this request! This is a very valid improvement.  We don't have this planned at this time but I will continue to collect customer demand to justify the commitment to support & maintain a high-quality Fivetran connector.

    Every upvote on this request increases the case to build it.

    Best, 

    Erin 

  • Craig Wilson User

    We would also like to have this improvement:

    Context
    We want to be running some analysis on our github data. In particular, we want to be able to analyse various pull request level metrics such as the lead time, the size of a PR or it's complexity. In particular we want to have access to the comments made on a pull request. With this, you can start identifying problematic pull requests or authors that tend to receive a lot more comments then others.
     
    Problem
    As seen on the data model here https://docs.google.com/presentation/d/1lx6ez7-x-s-n2JCnCi3SjG4XMmx9ysNUvaNCaWc3I_I/edit the datamodel exposes the comments made at the pull request level. It does not exposes the comments made at the file level within a pull request. Those are expected to have a commit sha, a filename, a start and end line.
     
    The relevant API is available here
    I've extracted the part of the json that is relevant
     
    [...]
    "body": "Great stuff!",
    "created_at": "2011-04-14T16:00:49Z",
    "updated_at": "2011-04-14T16:00:49Z",
    "html_url": "https://github.com/octocat/Hello-World/pull/1#discussion-diff-1",
    "pull_request_url": "https://api.github.com/repos/octocat/Hello-World/pulls/1",
    "author_association": "NONE",
    [...]
    "start_line": 1,
    "original_start_line": 1,
    "start_side": "RIGHT",
    "line": 2,
    "original_line": 2,
    "side": "RIGHT"
    [...]
     
    Proposed solution:
    Add a new table that stores those comments
  • Kyle Sullivan User

    We would also like to request this improvement.

    We are in the processing of building out a series of Engineering focused reporting processes, and would like more insight into the PR review process, including the number, type and content of PR review comments.

    We'd like to use the review comment data to identify languishing PRs and other bottlenecks in order to improve our code review process.

  • Erin Fivetranner

    Hi all - I wanted to let you all know that this feature is being brought up in the current sprint.

    Changing the status to "planned". 

    Best,

    Erin

  • Erin Fivetranner

    This has been rolled out to all customers.